slicersalt / ITKShape

ITK-Based Shape Analysis Filters (e.g Procrustes Alignment for Meshes)
Apache License 2.0
4 stars 5 forks source link

BUG: Rename and wrap #6

Closed tbirdso closed 3 years ago

tbirdso commented 3 years ago

This PR will resolve Issue 5.

tbirdso commented 3 years ago

build-test-cxx failures seem to occur in building ITK third party modules and not the external module?

[1007/2163] Building C object Modules\ThirdParty\OpenJPEG\src\openjpeg\CMakeFiles\itkopenjpeg.dir\bio.c.obj

FAILED: Modules/ThirdParty/OpenJPEG/src/openjpeg/CMakeFiles/itkopenjpeg.dir/bio.c.obj C:\PROGRA~2\MICROS~1\2019\ENTERP~1\VC\Tools\MSVC\1428~1.299\bin\Hostx64\x64\cl.exe /nologo -D_CRT_FAR_MAPPINGS_NO_DEPRECATE -D_CRT_IS_WCTYPE_NO_DEPRECATE -D_CRT_MANAGED_FP_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_DEPRECATE_GLOBALS -D_CRT_SETERRORMODE_BEEP_SLEEP_NO_DEPRECATE -D_CRT_TIME_FUNCTIONS_NO_DEPRECATE -D_CRT_VCCLRIT_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -IModules\ThirdParty\OpenJPEG\src\openjpeg -ID:\a\ITKMesh3DProcrustesAlignFilter\ITK\Modules\ThirdParty\OpenJPEG\src\openjpeg /DWIN32 /D_WINDOWS /W0 /MD /O2 /Ob2 /DNDEBUG /showIncludes /FoModules\ThirdParty\OpenJPEG\src\openjpeg\CMakeFiles\itkopenjpeg.dir\bio.c.obj /FdModules\ThirdParty\OpenJPEG\src\openjpeg\CMakeFiles\itkopenjpeg.dir\itkopenjpeg.pdb /FS -c D:\a\ITKMesh3DProcrustesAlignFilter\ITK\Modules\ThirdParty\OpenJPEG\src\openjpeg\bio.c D:\a\ITKMesh3DProcrustesAlignFilter\ITK\Modules\ThirdParty\OpenJPEG\src\openjpeg\opj_includes.h(106): error C2169: 'lrintf': intrinsic function, cannot be defined [1008/2163] Building CXX object Modules\IO\JPEG\src\CMakeFiles\ITKIOJPEG.dir\itkJPEGImageIOFactory.cxx.obj [1009/2163] Building CXX object Modules\IO\JPEG\src\CMakeFiles\ITKIOJPEG.dir\itkJPEGImageIO.cxx.obj

thewtex commented 3 years ago

@tbirdso let's update the CI to use v5.2rc03.

thewtex commented 3 years ago

Should be addressed by:

https://github.com/InsightSoftwareConsortium/ITK/commit/7cebc26dfae73d90dbf4702aa1ccc544e9b70a37

@tbirdso could you please update version in the CI configuration to be a Git commit hash for newer version of ITK master?