slidevjs / slidev

Presentation Slides for Developers
https://sli.dev
MIT License
31.92k stars 1.26k forks source link

Improve monospace and list formatting of notes #1712

Open gy-mate opened 6 days ago

gy-mate commented 6 days ago

Describe the bug

Monospace

Backticks of monospace notes are shown both in presenter mode and in exported notes:

Screenshot 2024-06-29 at 00 14 30 Screenshot 2024-06-28 at 23 43 18

I think that these monospace texts should look the same as in slides:

Screenshot 2024-06-28 at 23 43 38

Lists

I think that the spacing after indented note list items should be the same as after non-indented ones. (See the first two illustrations above.) I suggest the same for spacings before indented list items:

Screenshot 2024-06-29 at 00 18 59

Minimal reproduction

Steps to reproduce the behavior:

  1. Export the notes in my presentation:
    git clone https://github.com/gy-mate/kalauz
    cd kalauz/presentation
    git checkout 299e314a
    npx slidev
  2. Open http://localhost:3030/presenter/16
  3. See the monospace text in point no. 4 and the spacing after it
  4. Open http://localhost:3030/presenter/18?clicks=2
  5. See the spacing before the list element

Environment

antfu commented 6 days ago

Nice catch, I think we forgot to also replace the style for notes