search

slidings / pe

0 stars 0 forks source link

Possible missing arrows #4

Open slidings opened 1 week ago

slidings commented 1 week ago

There seems to be 3 different boxes that are floating and not connected to anything. They can be seen within the screen shot

image.png

nus-se-bot commented 3 days ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Missing classes in Model diagram

image.png

BuyingProperties and SellingProperties are listed above

But not:

image.png

[original: nus-cs2103-AY2425S1/pe-interim#882] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: NameContainsKeywordsPredicate, PhoneNumberContainsKeywordPredicate and TagContactContainsKeywordPredicate are the 3 fields that I was referring to. Not about missing "BuyingProperties and SellingProperties are listed above" as mentioned in the other referenced bug.

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** As a developer, I will very much want to trust developer notes to get up to speed with the entire code base without having to actually go through the entire code base in detail. Given that `NameContainsKeywordsPredicate`, `PhoneNumberContainsKeywordPredicate` and `TagContactContainsKeywordPredicate` are just floating there within UML diagram without any notation or explanation (shown below), it makes me even more confused about the purpose of such classes. "Is it a common's class?", "Is it a misplaced parser class?" or "did the developer forgot to remove them" etc. ![image.png](https://raw.githubusercontent.com/slidings/pe/main/files/76a8778e-a35d-4abe-869c-70fb4752d114.png) Upon further inspection of the actual code base, these 3 classes are found to be nested under Model>Person, alongside other very similar classes like `SellPropertyContainsKeywordPredicate` and `BuyPropertyContainsKeywordPredicate` which are not in the UML diagram. As someone who has worked on AB3, I am confused, I would believe that a new developer will be equally or perhaps more confused. As such this is given a medium instead of a low (which may be things like using dashed arrows instead of solid arrows)