search

slidoapp / dbt-coverage

One-stop-shop for docs and test coverage of dbt projects.
MIT License
197 stars 25 forks source link

dbt 1.1 / manifest v5 support ? #31

Closed aa-matthias closed 2 years ago

aa-matthias commented 2 years ago

Hi,

are you going to add support for manifest v5 as well? It's currently outputting a warning aying manifest v5 is not supported.

Thanks a lot!

mrshu commented 2 years ago

Hi @aa-matthias, this is indeed something we'll look at supporting in the future 🙂

reegs commented 2 years ago

@mrshu Based on the dbt version changelogs and the issues included in 1.1 related to the manifest 1 and 2, but in particular the first one I linked, it seems like dbt-core is treating version 5 of the manifest as compatible with version 4 so it shouldn't require any changes in parsing logic, just adding that versions 4 and 5 of the manifest can be treated the same by dbt-coverage

mrshu commented 2 years ago

Cool, thanks @reegs!

@sweco what do you say? Would it make sense to support the version 5 of the manifest as well?

sweco commented 2 years ago

Hey all, thank you all for analyzing the changes in the manifest. 😊 I'm marking manifest v5 to the list of the supported versions in https://github.com/slidoapp/dbt-coverage/pull/34.

sweco commented 2 years ago

Released in https://github.com/slidoapp/dbt-coverage/releases/tag/v0.2.1. Thank you for reporting the issue and thus helping with the development of the project! 😊