Custom run artifacts path

slidoapp / dbt-coverage

One-stop-shop for docs and test coverage of dbt projects.

MIT License

199 stars 25 forks source link

Custom run artifacts path #38

Closed Fszta closed 2 years ago

Fszta commented 2 years ago

Goal

Give more flexibility to user who have their manifest.json & catalog.json files not stored in /target, which is mainly the case for user using dbt cloud (need to retrieve the file by api call), adding a new parameter to use a custom path allow user not to create an unnecessary targetdir in their cicd pipeline

Description

Add run_artifacts_dir : Path parameter to load_manifest and load_catalog
Add optional run_artifacts_dir parameter to cli

mrshu commented 2 years ago

Hey @Fszta, thanks for adding this!

Would you happen to have a bit of time to resolve the conflict in __init__.py?

Thanks!

Fszta commented 2 years ago

Hi @mrshu, done :) I've slightly updated the error message to make it more consistent with both case, custom or default folder

mrshu commented 2 years ago

Thanks a lot @Fszta, this looks nice!

Would you mind adding yourself to the CHANGELOG.md similarly to https://github.com/slidoapp/dbt-coverage/pull/45/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR9 ? We can then easily merge this in 🙂

Thanks again!

mrshu commented 2 years ago

Sorry @Fszta, the merges from other PRs have made this such that there are again conflicts...

Would you mind resolving them one last time please?

mrshu commented 2 years ago

Thanks again @Fszta, this was now released in 0.3.0!

I also took the liberty of adding a bit of documentation on it in the README: https://github.com/slidoapp/dbt-coverage#custom-run-artifacts-path-with---run-artifacts-dir

Hope you like it!