search

slidoapp / dbt-coverage

One-stop-shop for docs and test coverage of dbt projects.
MIT License
197 stars 25 forks source link

Add support for dbt version 1.4 #59

Closed siljamardla closed 1 year ago

siljamardla commented 1 year ago

I am using dbt version 1.4.5:

dbt --version
Core:
  - installed: 1.4.5
  - latest:    1.4.5 - Up to date!

when I run dbt-coverage compute doc I get the following error about incompatibility

WARNING:root:Unsupported manifest.json version https://schemas.getdbt.com/dbt/manifest/v8.json, 
unexpected behavior can occur. 
Supported versions: [
'https://schemas.getdbt.com/dbt/manifest/v4.json', 
'https://schemas.getdbt.com/dbt/manifest/v5.json', 
'https://schemas.getdbt.com/dbt/manifest/v6.json', 
'https://schemas.getdbt.com/dbt/manifest/v7.json'
]. 
See https://github.com/slidoapp/dbt-coverage/tree/main#supported-dbt-versions for more details.

and the resulting stats are always 0/xxx columns documented.

sweco commented 1 year ago

Hey @siljamardla, sorry for a late reply. We were always testing our releases against the jaffle_shop project and it worked. I just tested it with dbt-core==1.4.6 and it works just fine.

However, we had problems with aliases https://github.com/slidoapp/dbt-coverage/issues/30. I just released dbt-coverage==0.3.3 that should fix this. Are you using aliases by any chance? If yes, could you please check whether it works?

siljamardla commented 1 year ago

Interesting. I can't remember doing any upgrades, but here's what I get now:

WARNING:root:Unsupported manifest.json version 
https://schemas.getdbt.com/dbt/manifest/v8.json, 
unexpected behavior can occur. 
Supported versions: [
'https://schemas.getdbt.com/dbt/manifest/v4.json', 
'https://schemas.getdbt.com/dbt/manifest/v5.json', 
'https://schemas.getdbt.com/dbt/manifest/v6.json', 
'https://schemas.getdbt.com/dbt/manifest/v7.json']. 
See https://github.com/slidoapp/dbt-coverage/tree/main#supported-dbt-versions for more details.

As opposed to last time, it does actually produce some stats.

sweco commented 1 year ago

@siljamardla, hmmm... That's intriguing indeed. Are you using dbt-coverage==0.3.3 or a different version?

Also, I can see that the issue had 3 upvotes. @StepienTomasz, @vvvito, @wmorin, did you also experience the issue with 0 coverage or you simply upvoted because of the warning?

sweco commented 1 year ago

@siljamardla, we've just released version 0.3.4 that removes the warning. Please, do let me know if you the zero coverage happens again.