slidoapp / dbt-superset-lineage

Make dbt docs and Apache Superset talk to one another
MIT License
134 stars 18 forks source link

Added dbt labels as part of columns info when pushing decscriptions #41

Open aibunny opened 8 months ago

aibunny commented 8 months ago

The labels are added in this format which I noticed is commonly used:

models:
  - name: book
    description: Book mart
    columns:
      - name: author
        description: The author
        label: Author
one-data-cookie commented 8 months ago

@aibunny Thanks for contributing, appreciate it!

As mentioned in #40, I think it needs to be put under meta.label, not just label (as this wouldn't show up in dbt Docs, otherwise).

Moreover, this should be also added to the opposite way, i.e. from dbt to Superset. Could you please look into that as well?

aibunny commented 8 months ago

@aibunny Thanks for contributing, appreciate it!

As mentioned in #40, I think it needs to be put under meta.label, not just label (as this wouldn't show up in dbt Docs, otherwise).

Moreover, this should be also added to the opposite way, i.e. from dbt to Superset. Could you please look into that as well?

Thanks lemme do that. I did that since it fit my use-case but after testing the meta.lable it now makes more sense, what do you mean the opposite way?

one-data-cookie commented 8 months ago

Thanks lemme do that.

Pefect, thanks!

what do you mean the opposite way?

Ignore me, I misread the code changes.

aibunny commented 8 months ago

ok, done

aibunny commented 8 months ago

I ran some functional tests because I didn't have any other tests to work with. Basically, I tested different cases: one with a metafield and labels, another with a metafield but no labels, and finally, a scenario with no metafield at all.

one-data-cookie commented 8 months ago

I ran some functional tests

You mean against dbt and Superset? Which versions did you use? Did it work as expected then?

aibunny commented 8 months ago

I ran some functional tests

You mean against dbt and Superset? Which versions did you use? Did it work as expected then?

yes , I used dbt 1.7 and superset api v1