search

slifty / tvarchive-canonical_wordpress

3 stars 3 forks source link

Race codes are wrong in some cases #70

Closed slifty closed 8 years ago

slifty commented 8 years ago

For candidates like Ted Cruz who ran for Senate in the past and for president now, their race codes are improperly linked to their old races in some cases. This is related to Issue #69 in that by using unique ID we would avoid this problem.

slifty commented 8 years ago

I'll be discussing with CRP tomorrow to better understand how they handle the situation where candidates run for multiple races.

slifty commented 8 years ago

After speaking with CRP here's the deal...

Race and Cycle for our ads comes from two possible places: candidates or sponsors

Candidate races / cycles provided by will always reflect the candidate's CURRENT race / cycle. This means that Marco Rubio is listed right now as running for FL senate even though he ran for president originally in this system.

Sponsors, similarly, are prone to have their race / cycle change. In some cases the sponsor race won't change -- for instance, candidate committees they should properly reflect the right race.

However at the end of the day the race of an ad should not be looked up in real time, but rather should be a metadata component of the ad itself. Issue #84 addressed this concept, and is now closed meaning this ticket can be closed from the perspective of the ads themselves.

However, from the perspective of the actual candidates and sponsors it should be noted that the race / cycles in the candidates table will reflect the CURRENT race. For the most part, races should never be looked up from these tables for the purposes of rendering -- at this point the only real use for that data is on initial ingestion of an ad (which will lock in today's race on an ad ingested today, and an administrator can fix it if needed.)

slifty commented 8 years ago

Since this question is answered and Issue #84 resulted in a code fix, this issue can now be closed.