slightech / MYNT-EYE-D-SDK

MYNT EYE D SDK (MYNT® EYE Depth Camera)
http://www.myntai.com/mynteye/depth
Other
99 stars 88 forks source link

IMU Coordinate system is wrong in SDK Document. #58

Open saikishor opened 5 years ago

saikishor commented 5 years ago

I am not sure, which is right, but the coordinate system mentioned in the document is completely different from the one in the ros wrapper. Please find the below for details:

The image from ROS Wrapper

Coordinate system from the Docs https://buildmedia.readthedocs.org/media/pdf/mynt-eye-d-sdk/latest/mynt-eye-d-sdk.pdf

I believe the ROS one is appropriate as the one in the docs seems to have the left handed one, but is mentioned as right handed.

Can someone please confirm which is right?

@yangruixuan @joinAero @harjeb any idea on this?

KalmanXiong commented 5 years ago

IMU coordinate system in document is right. This coordinate system based on the datasheet of the sensor(BMI088). However, the Ros one based on the map. I will report the issue to our team and decide that whether we should unified the two coordinate systems.

saikishor commented 5 years ago

@KalmanXiong I am not sure if it is right, because it doesn't represent the right hand system. As per your advice, I have checked the datasheet of BMI088 (https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMI088-DS001.pdf). I found the below image, in the page 44 of the document, which is clearly a right-hand system image

As per which aligning both and Z and X coordinate system the Y-axis should point downwards instead of upwards as per your documentation diagram. Then it makes sense and you would be able to obtain the same transformation in the ROS too.

Please kindly share your opinion on this. Thank you.

Moreover, I would kindly request you to report your team to fix the transformation of all the frames in the ROS, because all the frames are added to origin simply with respective rotations, but not a proper translation.

KalmanXiong commented 5 years ago

In our document, we indeed show the IMU coordinate system as right-hand system as well

saikishor commented 5 years ago

@KalmanXiong I completely agree, I was just referring to the coordinate system in the image. Where the Y-axis in theory should point in opposite direction. Could you please review and confirm this?.

If this is true, the coordinate system in ROS should just rotated by 180 degrees around Z-axis.

KalmanXiong commented 5 years ago

Please image that the coordinate system in the the datasheet of BMI088, flip up and down 180 degrees, and then turn 90 degrees counter clockwise. So you get the coordinate system in our doucment.

KalmanXiong commented 5 years ago

When you flip up and down the coordinate system, keep the x-axis direction the same, and then turn 90 degrees counter clockwise

saikishor commented 5 years ago

@KalmanXiong May be I am a bit confused, what do you mean exactly by flip up and down the coordinate system?. Rotate 180 degrees clockwise around Y-axis? or around X-axis?. Moreover, in one way or another, I see one of the frame pointing opposite. Can you please confirm about the flip?.

KalmanXiong commented 5 years ago

@KalmanXiong May be I am a bit confused, what do you mean exactly by flip up and down the coordinate system?. Rotate 180 degrees clockwise around Y-axis? or around X-axis?. Moreover, in one way or another, I see one of the frame pointing opposite. Can you please confirm about the flip?.

Rotate the coordinate system 180 degrees clockwise around X-axis, and then turn it 90 degrees counter clockwise around Z-axis.

saikishor commented 5 years ago

image

Ok got it, I made a simple sketch with the information. Now it makes sense. So as per the document image, the Y axis is will be pointing behind the camera right?. As shown in the above image.

I was confused with the coordinate system in the documentation, I thought the Y is pointing towards the front side of the camera.

@KalmanXiong Can you confirm this please?

KalmanXiong commented 5 years ago

1573711907(1) The image might could help you. I can confirm that the coordinate system in the documentation is correct.

saikishor commented 5 years ago

I am sorry but I couldn't agree with you, if you say this is right, then the documentation of IMU in MYNT-EYE-S is completely wrong, which I don't think so, I believe the coordinate system in the MYNT-EYE S IMU is Perfect. If you refer to the three IMU coordinate system, here (https://mynt-eye-s-sdk.readthedocs.io/en/latest/src/product/imu_coord_s2110.html, https://mynt-eye-s-sdk.readthedocs.io/en/latest/src/product/imu_coord_s2100.html, https://mynt-eye-s-sdk.readthedocs.io/en/latest/src/product/imu_coord_s1030.html). They all make sense and are right handed system.

But here, I couldn't think of a transformation for the frames, because it is represented by left-handed axis. I believe it should be something like: image

If you believe that what you represent is true, please help me with a proper transformation to obtain that coordinate system.

@KalmanXiong Please let me know something.

harjeb commented 5 years ago

Hi, have a look at this pic,the z axis is parallel with optic axis image2019-8-22_11-5-7

saikishor commented 5 years ago

@harjeb awesome where did you find the picture?. yeah you have the imu orientation in the image, from this we can get the proper orientation of the frame?. This means that X-axis coincides and Y points to the top of the camera and the Z-axis is parallel to the optic axis, but in opposite direction to global. This completely makes sense.

Could you please point me to the source?

KalmanXiong commented 5 years ago

What we discussed above is MYNT-EYE-D. why did you talk about MYNT-EYE-S suddenly?

saikishor commented 5 years ago

@KalmanXiong Yeah, they don't have any relation, but what i was mentioning is all of those IMU's are right handed system and their coordinate system make sense, when talking about Mynt Eye D, it is a right hand system, but the coordinate system representation is not exactly Right handed, that's what i am pointing out above.

I guess what @harjeb pointed out could be right. Do you know it's source?

harjeb commented 5 years ago

Hi @saikishor , this picture is internal data, and I have confirmed it is correctly

saikishor commented 5 years ago

@harjeb Thanks for the update, would you be kind enough to share the similar picture with measurements, this will help me to define my frames in ROS, which is very important from sensor point of view, having an offset in frames creates a bigger problems in future. I hope you don't mind.

Once I am done with proper frames, I can create a PR to the repo.

saikishor commented 5 years ago

@harjeb From here, I know the placement in 2D, but It would be helpful if you can share the picture with the measurements from top view, so I can create perfect frames.

saikishor commented 5 years ago

Hi, have a look at this pic,the z axis is parallel with optic axis image2019-8-22_11-5-7

Here, Where will exactly be the depth frame?

saikishor commented 5 years ago

@harjeb can you please comment on my request earlier?

harjeb commented 5 years ago

@saikishor Hi , there‘s no top view right now

saikishor commented 5 years ago

@harjeb thanks for update. Do you know how deep is the sensor placed from the front end of the device.?

saikishor commented 4 years ago

@harjeb and @KalmanXiong We are planning to use Mynt Eye D cameras for our robots. Do you have an estimate, when these documents are available to public to have a proper frames in ROS. Out of the topic, when can we also estimate support for multiple cameras?

saikishor commented 4 years ago

@harjeb and @KalmanXiong Can you please comment on this?

harjeb commented 4 years ago

We still have problems to solve, it‘s hard to say when it will be ready.

saikishor commented 4 years ago

@harjeb Thanks for the update. :)

harjeb commented 4 years ago

We still have problems to solve, it‘s hard to say when it is ready.

ahmetsaglam commented 4 years ago

@harjeb and @KalmanXiong We are planning to use Mynt Eye D cameras for our robots. Do you have an estimate, when these documents are available to public to have a proper frames in ROS. Out of the topic, when can we also estimate support for multiple cameras?

Hi all, Is there any progress on the documentation for this specific matter? We are also planning to use Mynt Eye D cameras and IMU for our robots and I need this information immediately.

RaviBeagle commented 2 years ago

Hi, have a look at this pic,the z axis is parallel with optic axis image2019-8-22_11-5-7

Is this final correct co-ordinate system of IMU ? Also z is parallel to optic axis and directed backward ?