search

slightlynybbled / tk_tools

Python tkinter tools, Python3.7+
MIT License
101 stars 25 forks source link

ButtonGrid implementation/doc + ByteLabel doc #16

Closed AokiAhishatsu closed 6 years ago

AokiAhishatsu commented 6 years ago

Check this out. Needs some testing.

AokiAhishatsu commented 6 years ago

Some lines are too long. Sry about that.

slightlynybbled commented 6 years ago

You can click on the details and see what went wrong, right? I just want to make sure that you can see what is going on from your side as well with travis.

If you run python setup.py flake8 as part of your testing locally, you should be able to see all flake8 violations before commit or as part of your normal workflow.

I don't want the flake8 to get in the way of helping, which is why I spent a few hours getting the code to conform to flake8 - including the automatically generated image strings - so it should be quite easy to work into your normal workflow. You should get failures any time you try to run setup.py and have flake8 errors.

I like the changes and I am going to check them myself before the merge, but probably won't be able to get to it before this evening. Thank you for all of the work!