search

slightlynybbled / tk_tools

Python tkinter tools, Python3.7+
MIT License
101 stars 25 forks source link

Add running examples in IDE for convenience #28

Closed ReblochonMasque closed 6 years ago

ReblochonMasque commented 6 years ago

Many commits, but no biggie: I mostly added if __name__ == '__main__': in the examples, and renamed a couple of functions and variables.

I manually ran each example before and after refactoring, and all seemed okay; however, the project is in dire need of tests if more serious improvements are to happen.

There is an unintended change in Canvas. It happened as a consequence of renaming a global variable; I left it as it seemed appropriate.

I am pulling directly to master; the development branch seemed unmaintained and far behind.

Please let me know if you wish something modified. Cheers Fred

slightlynybbled commented 6 years ago

I agree with the comment about tests. I generally try to have automated testing in my non-toy applications, but I haven't taken the time to figure that out within the tkinter context. When programming a GUI, I generally try to make the UI the thinnest layer possible... reducing the chances of abnormal behavior. Would love to see some testing added if you find yourself with some time! I generally prefer pytest, but I'm willing to go with anything that represents a relatively modest jump to travisci or similar services. Basic flake8 styling is already implemented.

ReblochonMasque commented 6 years ago

Yes, we are in agreement. There are two problems with code w/o tests:
1- it is very difficult to refactor it safely. i/e very difficult to accept and merge significant pull requests. 2- it remains a toy until thoroughly tested. That is the number of people willing to use the lib will be very limited.