New Definitions / Resolve Issue Backlog

tshedor commented 8 years ago

Apologies for the massive code dump; I'll do my best to humanize the work in this PR comment.

Screenshots

Before

Before

After

After

Converts the .tmLanguage to its YAML equivalent in Syntaxes/Ruby Slim.YAML-tmLanguage. This will require an extra build step, but the improved legibility is worth it.
A sample page to visually confirm the highlighting works as intended is provided in Demo/demo.slim. Its contents aim to cover as many edge cases as possible.
Features
Added filters for erb: and less:
Definitions for initial selectors (. or # shortcuts or HTML tags like span)
Definitions for . and # shortcut separators (i.e. span.my-class#my-id)
Definitions for attributes (i.e. a.my-class#my-id href="#")
Definitions for constants true, false, and nil when used as attribute values
Definitions for splats (i.e. a *{href: '#'})
Definitions for inline tags (i.e. p: span.my-new-tag)
Bugfixes
Support for the bracket attribute wrapper (i.e. span[attribute="value" other-attribute="other-value"])
20 (related comment)
38
47 and #53
56
58

(Unrelated: #23 and #41 seem complete)

kreintjes commented 8 years ago

I am currently using the latest version from tshedor:master (https://github.com/tshedor/ruby-slim.tmbundle) with Sublime Text 3 and so far it works like a charm. Thanks @thsedor!

fredwu commented 8 years ago

Great work! 👍 I am happy to merge this big PR when @tshedor feels it's ready and stable. :)

tshedor commented 8 years ago

@fredwu Merge away! I was able to test on ST2 today and only encountered one [quickly resolved] bug. Thanks!

fredwu commented 8 years ago

Awesome, thanks @tshedor! 👏

Merging this, everyone please give this a try and report any issues. 😈