search

slim-template / ruby-slim.tmbundle

A Textmate / Sublime Text bundle for Slim
http://slim-lang.com/
MIT License
185 stars 46 forks source link

Fix: issue #70 #71

Closed elquimista closed 7 years ago

elquimista commented 7 years ago

Reference #70

tshedor commented 7 years ago

This removes highlighting for the next line. For example,

/ This comment will designate "tag" on the next line as a comment
tag
elquimista commented 7 years ago

@tshedor What do you mean?

tshedor commented 7 years ago

@clthck Your proposed change affects text at the same indentation level: image

Versus how it should be highlighted according to the Slim spec (using the definitions from the package in its current release): image

ST3 added/revised syntax highlighting features, and that's affected this package. However, the latest release (3143) seems to resolve some highlighting issues that appeared in beta releases (like this one and the block comments on #74) while some are still broken (#72 via #53).

elquimista commented 7 years ago

Seen from the screenshot, isn't it because of being wrapped in IE comment section?

tshedor commented 7 years ago

@clthck Oh, that's a great point. You're right. Sorry about that.

Last thing, I swear: would you please apply the same change to the YAML file? It helps maintenance and legibility/seems Sublime's preference.

elquimista commented 7 years ago

@tshedor YAML file updated.

tshedor commented 7 years ago

Thanks @clthck

skunkworker commented 7 years ago

Thanks. This fixed it for me.