Splat builder that works with ActionView::OutputBuffer

slim-template / slim

Slim is a template language whose goal is to reduce the syntax to the essential parts without becoming cryptic.

https://slim-template.github.io

MIT License

5.29k stars 500 forks source link

Splat builder that works with ActionView::OutputBuffer #941

Closed olleolleolle closed 9 months ago

olleolleolle commented 9 months ago

This sketch of "have it work with Rails 7.1" for my app, it reacts to the fact that OutputBuffer no longer derives from String.

I wanted to share this as soon as I had something that could possibly work, so I added no other long thoughts or good tests to this. I'd like feedback, thoughts, whether this can be checked at a much earlier stage, etc.

minad commented 9 months ago

Could you please add a test cases which fails without this change and succeeds with it?

olleolleolle commented 9 months ago

I hope to!

minad commented 9 months ago

Fixed by #942