search

slim-template / slim

Slim is a template language whose goal is to reduce the syntax to the essential parts without becoming cryptic.
https://slim-template.github.io
MIT License
5.3k stars 501 forks source link

Fix splat arguments on Rails 7.1 #942

Closed francescobbo closed 12 months ago

francescobbo commented 12 months ago

OutputBuffer has been changed to not inherit from String (and using the output safety core_ext from activesupport). With that change, the + has been removed.

This change replaces the += operator with concat, which is available on Strings and OutputBuffers alike.

I've added a test that fails without my patch on Rails 7.1.

bobmaerten commented 11 months ago

Could we expect a release soon, now this is fixed?

minad commented 11 months ago

@bobmaerten I will wait a little longer if more Rails 7.1 related issues pop up, see for example #943.

gstokkink commented 11 months ago

@minad I second the request for a release, this would help us a lot. That other bug you're referring to will be fixed in Rails 7.1.2, which is still a ways off.

ryoung commented 11 months ago

Any chance of a release? This fix has been merged a month ago.

mgrunberg commented 10 months ago

@minad would you consider a release now that Rails 7.1.2 got released? At least a rc.

minad commented 10 months ago

Thanks. I noted the interest in an early release. ~But note that Rails 7.1.1 will still lead to breakage (#943).~ (EDIT: I see that Rails 7.1.2 has been released yesterday, so we should definitely proceed with this soon.) If Slim is useful for you, please consider supporting the maintenance of the project.