search

slimcoin-project / Slimcoin

SLIMCoin official repository
https://slimcoin-project.github.io
MIT License
28 stars 13 forks source link

fix: Qt warning in OptionsModel #7

Closed brakmic closed 7 years ago

brakmic commented 7 years ago

Not sure if this is worthy of a pull request but I've spotted a warning that appears during the app start:

No such signal OptionsModel::reserveBalanceChanged(qint64) in src/qt/overviewpage.cpp:267

In optionsmodel.h the signal reserveBalanceChanged(qint64 resbal) swas commented out, for whatever reason. Maybe some upcoming changes I know nothing about?

Regards,

brakmic commented 7 years ago

something is wrong with my pull request. Actually I wanted to change a single line. Will now close it and checkout again. 😄

ghost commented 7 years ago

No problem. Looks like you have code from the master branch overlaying the slimcoin branch. The bitcointalk thread carries much discussion of the impact of accumulated recursively-staking stake reward txs on the functioning of the wallet. Not an unknown issue for PoS coins, aiui. Remediation is usually via restriction (staking=no/reservebalance=nnn). slimcoin uses a reservebalance approach. Setting a non-zero value is such an important userland issue in Slimcoin that I had a go at adding a GUI component, following the existing model. Except I haven't yet got round to grokking Qt's signalling architecture and I haven't figured out how to get the changed value from the dialog box back into the main wallet engine. There's also the issue of: the value can be set in config, command-line and now GUI, what are the override priorities? I would welcome any suggestions.

brakmic commented 7 years ago

I've recreated this pull-request. I should avoid manual .git/config edits 🌵 However, my wallet is still at block 1037662.

Messages like this one appear all the time. ERROR: CheckProofOfBurn() : INFO: prev block not found WARNING: ProcessBlock() : check proof-of-burn failed for block 1e96f7919c5dbb658d412536038e66b5188cb3f88bd85f202c7afa65985d4f8f connection timeout

Don't know if I should open a new issue. But, it's not that important to me as I'll be testing Slimcoin only for some time and then move on to another 💩 coin.