slimcoin-project / pacli

Simple CLI PeerAssets client (extended version).
GNU General Public License v3.0
0 stars 0 forks source link

token transfer with the -v flag #110

Closed buhtignew closed 3 months ago

buhtignew commented 3 months ago

I've tested the following commands:

token transfer fb93cce7aceb9f7fda228bc0c0c2eca8c56c09c1d846a04bd6a59cae2a895974 n4UW9h3QvBRxdF9prmT8cP8p13Vm8VYJn9 0.1 -v token transfer fb93cce7aceb9f7fda228bc0c0c2eca8c56c09c1d846a04bd6a59cae2a895974 n4UW9h3QvBRxdF9prmT8cP8p13Vm8VYJn9 0.1 -v FALSE token transfer fb93cce7aceb9f7fda228bc0c0c2eca8c56c09c1d846a04bd6a59cae2a895974 n4UW9h3QvBRxdF9prmT8cP8p13Vm8VYJn9 0.1 -v=FALSE token transfer fb93cce7aceb9f7fda228bc0c0c2eca8c56c09c1d846a04bd6a59cae2a895974 n4UW9h3QvBRxdF9prmT8cP8p13Vm8VYJn9 0.1 -v=TRUE token transfer fb93cce7aceb9f7fda228bc0c0c2eca8c56c09c1d846a04bd6a59cae2a895974 n4UW9h3QvBRxdF9prmT8cP8p13Vm8VYJn9 0.1 -v TRUE token transfer fb93cce7aceb9f7fda228bc0c0c2eca8c56c09c1d846a04bd6a59cae2a895974 n4UW9h3QvBRxdF9prmT8cP8p13Vm8VYJn9 0.1 -v True token transfer fb93cce7aceb9f7fda228bc0c0c2eca8c56c09c1d846a04bd6a59cae2a895974 n4UW9h3QvBRxdF9prmT8cP8p13Vm8VYJn9 0.1 -v false

and in each case I've got the following error:

  File "~/.local/bin/pacli", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "~/.local/lib/python3.12/site-packages/pacli/__main__.py", line 479, in main
    fire.Fire({
  File "~/.local/lib/python3.12/site-packages/fire/core.py", line 143, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~/.local/lib/python3.12/site-packages/fire/core.py", line 477, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
                                ^^^^^^^^^^^^^^^^^^^^
  File "~/.local/lib/python3.12/site-packages/fire/core.py", line 693, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
                ^^^^^^^^^^^^^^^^^^^^^^
  File "~/.local/lib/python3.12/site-packages/pacli/extended_classes.py", line 1327, in transfer
    return ei.run_command(self.__transfer, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~/.local/lib/python3.12/site-packages/pacli/extended_interface.py", line 33, in run_command
    result = c(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^
  File "~/.local/lib/python3.12/site-packages/pacli/extended_classes.py", line 1353, in __transfer
    return eu.advanced_card_transfer(deck,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~/.local/lib/python3.12/site-packages/pacli/extended_utils.py", line 401, in advanced_card_transfer
    return finalize_tx(issue_tx, verify=verify, sign=sign, send=send, quiet=quiet, confirm=confirm, debug=debug)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "~/.local/lib/python3.12/site-packages/pacli/extended_utils.py", line 235, in finalize_tx
    cointoolkit_verify(rawtx.hexlify())
  File "~/.local/lib/python3.12/site-packages/pacli/utils.py", line 18, in cointoolkit_verify
    return base_url + "?" + mode + "&" + "verify=" + hex
                            ^^^^
UnboundLocalError: cannot access local variable 'mode' where it is not associated with a value
d5000 commented 3 months ago

Just saw that the cointoolkit_verify mode doesn't work with Slimcoin at all. This is done on a Peercoin website. So I have disabled the option for Slimcoin (it will be visible but help is changed to "Peercoin only").

Commit 8428672

Can be closed.

buhtignew commented 3 months ago

I think there are other places in help where the cointoolkit is mentioned, in fact I always wanted to ask you what is it, but I don't remember to have had flags that mentions cointoolkit that just doesn't work for slimcoind.

d5000 commented 3 months ago

It's always the -v option and I've revised all help.