search

slimcoin-project / pacli

Simple CLI PeerAssets client (extended version).
GNU General Public License v3.0
0 stars 0 forks source link

address list -p -i output #128

Closed buhtignew closed 2 months ago

buhtignew commented 3 months ago

I don't know whether it's relevant, however while my address list -p output is :

+Addresses:--------+------------------------------------+---------+--------------+----------------------------------------------------------------------------+
| Label            | Address                            | Network | Coin balance | P2TH account                                                               |
+------------------+------------------------------------+---------+--------------+----------------------------------------------------------------------------+
| no_transactions? | mqZ5nqs6bpaAqEoEV9jVFfwsM3hBZD4C3J | tslm    | 0.05         | a2459e054ce0f600c90be458915af6bad36a6863a0ce0e33ab76086b514f765aLOCKING    |
|                  | n4HXAq2XjJAt4cNRL9gpPjDS7r8hxmghVR | tslm    | 0.01         | 95b24015ffb46d82015b709d774542fc4a53ccf27f72d973ed3fb18c384a80ca           |
|                  | n1WEs2vcEbXFQWe6GtsFgHfQmzavHVYMi4 | tslm    | 0.07         | a2459e054ce0f600c90be458915af6bad36a6863a0ce0e33ab76086b514f765aPROPOSAL   |
|                  | muhhYam1NXMSUqKx4uSrfjS7N7Fcz6j6Qx | tslm    | 0.01         | f7b1af6d565898851878cb13c88bb52996a0a5380c4ea8803c248a69c7d00d82           |
|                  | mgLyx4nNSPjcimazmo5U2Z8khUiRZWq5hn | tslm    | 0.08         | e9c2c5bdfdd46372111ec29bf8f30ae39177cf1042ff94b6911e53048c78c0c5           |
|                  | mzP9BNtqjSNq2rJ58w8GpQNnez38NGagsU | tslm    | 0.03         | a2459e054ce0f600c90be458915af6bad36a6863a0ce0e33ab76086b514f765aDONATION   |
|                  | myKpK8viS9k8JSWEA9syitxLJUTqdSeSvr | tslm    | 0.01         | 63402dbbeb280d41701f2a23caac226e938ff354daec0ff8bd7903ac59696284           |
|                  | miHhMLaMWubq4Wx6SdTEqZcUHEGp8RKMZt | tslm    | 0.12         | PAPROD                                                                     |
|                  | mguM6Xso6UEVT8uPYGnFMw9aPBZ2vtRKoH | tslm    | 0.08         | 3369f3eb703656c0b46b613dcfb4df78fc05657a0b75f44551634de6321d9d9cSIGNALLING |
|                  | mxfu9BNbsaECVVBRiqzavcvp6xhB2cz9r8 | tslm    | 0.09         | 3369f3eb703656c0b46b613dcfb4df78fc05657a0b75f44551634de6321d9d9cLOCKING    |
|                  | mz6HENDiSFPYqsi7wDZ33p5jt7j9LFo6qr | tslm    | 0.02         | 7a2ae406ddf44ddb17532d4888fdc14573f52749445e9e014075c9f83cbe556f           |
|                  | mvuMyLkLkYKtnq3DkPY6Xe91AYthEGcfym | tslm    | 0.08         | a2459e054ce0f600c90be458915af6bad36a6863a0ce0e33ab76086b514f765aVOTING     |
|                  | mxasNazVpdfTmjQcedfxtHQtb3NXKVGEzh | tslm    | 0.03         | a2459e054ce0f600c90be458915af6bad36a6863a0ce0e33ab76086b514f765a           |
|                  | mgiYjQjREbtKcKKH1kFXo1ycWCfGB5aZd7 | tslm    | 0.04         | a2459e054ce0f600c90be458915af6bad36a6863a0ce0e33ab76086b514f765aSIGNALLING |
|                  | moDgh2HgPZKWpFrNesC4QVBzvBrV79p9pA | tslm    | 0.07         | 3369f3eb703656c0b46b613dcfb4df78fc05657a0b75f44551634de6321d9d9c           |
|                  | mkwJijAwqXNFcEBxuC93j3Kni43wzXVuik | tslm    | 0.26         | fb93cce7aceb9f7fda228bc0c0c2eca8c56c09c1d846a04bd6a59cae2a895974           |
|                  | mqnBdCH2cuoSiQWjKoEZHfov77bzrpmtNX | tslm    | 0.06         | 3369f3eb703656c0b46b613dcfb4df78fc05657a0b75f44551634de6321d9d9cPROPOSAL   |
|                  | mmjaHuS1kTRMFJaTJqYMjdmF18n36eXHfD | tslm    | 0.04         | 3369f3eb703656c0b46b613dcfb4df78fc05657a0b75f44551634de6321d9d9cDONATION   |
|                  | mtvQZrb9BC8HFtXe87Ev5PEUeA1cSvP211 | tslm    | 0.14         | 3369f3eb703656c0b46b613dcfb4df78fc05657a0b75f44551634de6321d9d9cVOTING     |

The address list -p -i command outputs:

+Addresses:--------+------------------------------------+---------+--------------+----------------------------------------------------------------------------+
| Label            | Address                            | Network | Coin balance | P2TH account                                                               |
+------------------+------------------------------------+---------+--------------+----------------------------------------------------------------------------+
| no_transactions? | mqZ5nqs6bpaAqEoEV9jVFfwsM3hBZD4C3J | tslm    | 0.05         | a2459e054ce0f600c90be458915af6bad36a6863a0ce0e33ab76086b514f765aLOCKING    |
|                  | mmokjFrXkEZ6PChmWruu3nZbfs1okQw5Rw | tslm    | 0            | 8170a5d2e0efb69b178d95be6cd04ffd957486b0b9e1e8ca2dbce3e6f710e10b           |
|                  | mxjbB1tjRzr3hFnv5JAvkieADS1EZVn4Ee | tslm    | 0            | aea9a13a0a0924d22b46bced4a2690d56520b88b0159ec8a844b70ee3a94cd5b           |
|                  | mgMnRiMxfxsFgaaAahJFenvDxSJ1DtVour | tslm    | 0            | 27b66d757332ec9412c528522a308905e923d7114e70e657762ab12edb12fa55           |
|                  | n4765PPUYdUgzur6tyxH81SKYmLmKwREev | tslm    | 0            | 75b324876cbfbc49af37ff9bcbba1fc5493e10ce89b0cae6f05168539b3cdea8           |
|                  | mgiYjQjREbtKcKKH1kFXo1ycWCfGB5aZd7 | tslm    | 0.04         | a2459e054ce0f600c90be458915af6bad36a6863a0ce0e33ab76086b514f765aSIGNALLING |
|                  | n29mSoozF9bDBAJgHKdgyyK5GZcDDfyhvm | tslm    | 0            | 35b886c6ed16c3ace35ee59b6777e3a286e317a64715bbe3f080e16d8e5f52a4           |
|                  | n3yLWRKczsgTtDtDcemG7wN43Kt5cDjK6j | tslm    | 0            | 0b3816628374d24078c741251f712b7f6af1c6f82ff7ddce083c20a58fcc2bc1           |
|                  | myKpK8viS9k8JSWEA9syitxLJUTqdSeSvr | tslm    | 0.01         | 63402dbbeb280d41701f2a23caac226e938ff354daec0ff8bd7903ac59696284           |
|                  | mp5zpXDLxTn24XPai5BX1mkd2XZxhAwxfe | tslm    | 0            | 160679b53e6785664e75bc3cde5e1c41e88a9aacc8afcc92b641152f51dec959           |
|                  | mmELMxHM7L1hYYbzNxTeZKpMEyHczstW1W | tslm    | 0            | 539839eb5c3a3dbf1eb9b942f4a8126b58a7733efaf9d1f3ccba86904b6fcee3           |
|                  | mxfu9BNbsaECVVBRiqzavcvp6xhB2cz9r8 | tslm    | 0.09         | 3369f3eb703656c0b46b613dcfb4df78fc05657a0b75f44551634de6321d9d9cLOCKING    |
|                  | msLk3yU64FAft2rB1iG9iVCSiPypS1pEFW | tslm    | 0            | 0b3816628374d24078c741251f712b7f6af1c6f82ff7ddce083c20a58fcc2bc1VOTING     |
|                  | mxasNazVpdfTmjQcedfxtHQtb3NXKVGEzh | tslm    | 0.03         | a2459e054ce0f600c90be458915af6bad36a6863a0ce0e33ab76086b514f765a           |
|                  | mnwzbFeNR3mmaL94LMGwArzwvgHJJWcQTu | tslm    | 0            | 0a5a0072a03ba7b307ad95ef95c074571fafba7b35f97bfe11ade8f1807bfc32           |
|                  | mtvQZrb9BC8HFtXe87Ev5PEUeA1cSvP211 | tslm    | 0.14         | 3369f3eb703656c0b46b613dcfb4df78fc05657a0b75f44551634de6321d9d9cVOTING     |
|                  | n2i8JHG9vWgnQHDQGmoKhkyvm3Pp69oSc3 | tslm    | 0            | 1d8b3d918a35db90d8c68fa303a28bf12463e0aa84e1f06df977ca8f584dc9eb           |
|                  | mqnBdCH2cuoSiQWjKoEZHfov77bzrpmtNX | tslm    | 0.06         | 3369f3eb703656c0b46b613dcfb4df78fc05657a0b75f44551634de6321d9d9cPROPOSAL   |
|                  | mqR3iBYqKprpqjxxZgAtD1jizZxVqc9dh4 | tslm    | 0            | 66c25ad60538a9de0a7895d833a4a3aeeacdd75b1db9c5dd69c3746dd21d39be           |
|                  | mmjaHuS1kTRMFJaTJqYMjdmF18n36eXHfD | tslm    | 0.04         | 3369f3eb703656c0b46b613dcfb4df78fc05657a0b75f44551634de6321d9d9cDONATION   |
|                  | n4HXAq2XjJAt4cNRL9gpPjDS7r8hxmghVR | tslm    | 0.01         | 95b24015ffb46d82015b709d774542fc4a53ccf27f72d973ed3fb18c384a80ca           |
|                  | mhJJjfBEp2h112WMmYVHRWjTevDw34nXx6 | tslm    | 0            | 6f3e02966a6dd63e478267794a114ec183f4218667e796c79e93f772e6bc281a           |
|                  | mzP9BNtqjSNq2rJ58w8GpQNnez38NGagsU | tslm    | 0.03         | a2459e054ce0f600c90be458915af6bad36a6863a0ce0e33ab76086b514f765aDONATION   |
|                  | mwTkKtTGo4AGVNhha5kRLpm3KJZkNgaVyb | tslm    | 0            | 2d54c63198230fb6edcda209e5f2f16866c6ce71e21e6106f51efe755f56a53d           |
|                  | msTvZC5TmuGWqFrfYhfey3L2w5FxYKbKEk | tslm    | 0            | ecfbc2cbdca47ab8f0ab4c0f4e6a1f0496105778af879e7a31921b92cff5d080           |
|                  | msc6oPRoJQ2dZTQWJbfjPoQnubzWRSb9DG | tslm    | 0            | be86176f07821b0ec9c2a531404e56fbaa371581c9625f16fe5ab3f55a3614a1           |
|                  | moDgh2HgPZKWpFrNesC4QVBzvBrV79p9pA | tslm    | 0.07         | 3369f3eb703656c0b46b613dcfb4df78fc05657a0b75f44551634de6321d9d9c           |
|                  | muHAt23T3RgegVqrwwNVopW9Z4sqKWoZFA | tslm    | 0            | 6bd1f9d929b30d96ef4fc067acd966b5b563c7eea336bd571caf150582bae122           |
|                  | mtvEMck8nyBiYnZtqX5gqRiVGfKdgTJepF | tslm    | 0            | eff38339e7b84cff228c028c7c40d7861efe5d217a78af0ce014f30fea6248d9           |
|                  | mkwJijAwqXNFcEBxuC93j3Kni43wzXVuik | tslm    | 0.26         | fb93cce7aceb9f7fda228bc0c0c2eca8c56c09c1d846a04bd6a59cae2a895974           |
|                  | n4bUzq2yA2D9pwtVVheX5L5yZkBBmEMyec | tslm    | 0            | a843d6bec0da495ea0cc03fcd36942598ba9f786547a800721c0e78b99c0adca           |
|                  | my8tpQTa4prvywNvgNx9PUhypDdDEynmQV | tslm    | 0            | 5bb036be7522a5b2ad2db4c3c0cb16fccf4852bfc9f79febb7028859dc468307           |
|                  | miHhMLaMWubq4Wx6SdTEqZcUHEGp8RKMZt | tslm    | 0.12         | PAPROD                                                                     |
|                  | mrwqCgozjvfjYhwEei275eAba3c78aUgHS | tslm    | 0            | 0b3816628374d24078c741251f712b7f6af1c6f82ff7ddce083c20a58fcc2bc1SIGNALLING |
|                  | mkPxci8U3FMbMr6eKZ5RPMmREe5XSRxkpq | tslm    | 0            | 0b3816628374d24078c741251f712b7f6af1c6f82ff7ddce083c20a58fcc2bc1LOCKING    |
|                  | mgxZTaRYsdqu4Rh1MLJu8Abw9YoPKq8rqS | tslm    | 0            | 00f37640c4c5844f587686fb188324db5bf9428ecc0d1d31a0c6ed9258acf186           |
|                  | mz6HENDiSFPYqsi7wDZ33p5jt7j9LFo6qr | tslm    | 0.02         | 7a2ae406ddf44ddb17532d4888fdc14573f52749445e9e014075c9f83cbe556f           |
|                  | n1WEs2vcEbXFQWe6GtsFgHfQmzavHVYMi4 | tslm    | 0.07         | a2459e054ce0f600c90be458915af6bad36a6863a0ce0e33ab76086b514f765aPROPOSAL   |
|                  | mqZLm4kfW7ZQTHxs99iqh7HwSaBs6shot9 | tslm    | 0            | 0b3816628374d24078c741251f712b7f6af1c6f82ff7ddce083c20a58fcc2bc1PROPOSAL   |
|                  | n3WUiDRZLXnQ3FC2saJf7Ef1rJP6TgUEDK | tslm    | 0            | 0dd9ddc9434c912f5ac7facdb51efb011e2d38aff2f52974740be51e2a5498bb           |
|                  | mwgZKcPXEv6ZvXdbVLZKrUhoYyio9F1c74 | tslm    | 0            | dbefb8c9fcb4ed2bb2722abb177188b9e7d8cde55e4163fff9c5e5ca374706e1           |
|                  | mjHjrWRjRN7p6j7etgi7Wp7uiSfvngLAZX | tslm    | 0            | d65f9f83e51ff52b9d5c839be432b980dbfd452ed7f5e28a105d3c2ac254de33           |
|                  | mgyEJwNhisay5NfEfUvFRvnE3NKufhESVe | tslm    | 0            | 0f8ce9e852bc43a20b185c839bc550ce7c5b22c464c10423e58ab399c5275ffa           |
|                  | mguhnvesU3Qb8jrtKZ9B2URz63GBHsBZ5G | tslm    | 0            | dc74609db0db6e1d50cf59e1f5591864513607152b5c0d5a93e3eee9c4139183           |
|                  | muhhYam1NXMSUqKx4uSrfjS7N7Fcz6j6Qx | tslm    | 0.01         | f7b1af6d565898851878cb13c88bb52996a0a5380c4ea8803c248a69c7d00d82           |
|                  | mvfR2sSxAfmDaGgPcmdsTwPqzS6R9nM5Bo | tslm    | 0            | PATEST                                                                     |
|                  | mqc8cfRK6z8xrBApf6Uzd7dKY1FB1kJ9aP | tslm    | 0            | 0b3816628374d24078c741251f712b7f6af1c6f82ff7ddce083c20a58fcc2bc1DONATION   |
|                  | mvuMyLkLkYKtnq3DkPY6Xe91AYthEGcfym | tslm    | 0.08         | a2459e054ce0f600c90be458915af6bad36a6863a0ce0e33ab76086b514f765aVOTING     |
|                  | mk9yxmiRhS6gr7H3or7TLD8evy4kmrLagP | tslm    | 0            | 7984c5d710862fb624a9b1f3678fe277f62d25590ff71158a9dfa1556650560a           |
|                  | mgLyx4nNSPjcimazmo5U2Z8khUiRZWq5hn | tslm    | 0.08         | e9c2c5bdfdd46372111ec29bf8f30ae39177cf1042ff94b6911e53048c78c0c5           |
|                  | mguM6Xso6UEVT8uPYGnFMw9aPBZ2vtRKoH | tslm    | 0.08         | 3369f3eb703656c0b46b613dcfb4df78fc05657a0b75f44551634de6321d9d9cSIGNALLING |
|                  | mvB53f5meBSEpnh3AeFv1GCaDAPRVKY9jq | tslm    | 0            | 19dbea6a6011e5f453cb90cdf527d788c8bd7d9e30d6ad585a31df4ef96f61c5           |
|                  | n1o3664EJiDZxFr918q1oncWATsVbiKwXS | tslm    | 0            | ac0f950a8fd4a8ee8d710a2463ee3c42e3f8a8fc7779e43e63810d12117d7be4           |
|                  | mhXuMH4kwY3Mi9pLMh3QxaweWfXL5toPYX | tslm    | 0            | 08dd2a01a138e045603d9eb6c6a5ace6dfe185e0a1c71490a9bd2ac0afbcfaa3           |
|                  | mvuKa2wnCoiSC6Av9MyotxMDxzWsFZMYTT | tslm    | 0            | 779e297ed821b92afff6a8b3c8e54dfef0106a532a5d03e3e5f3e22fe0ba5490           |
|                  | mzVgi8SZXoZk6tPrhET3mB2suYzfTzf5iT | tslm    | 0            | 9c5683767130131e064a8f7429f469624fb9a83ab4e94f35d62d01c911263603           |
|                  | mpxQqMGfBZpktCCxp3D9AHT8y8bjV1mUoC | tslm    | 0            | 48a3db788c0f712f73bb6ad6446d3af0f80d55d1975462af0bf9737da613ce2f           |
|                  | n1Dwv8ruoznasjTGVuEpWgCP89LxNCWTwd | tslm    | 0            | a18507319f50ffe0748c98590882a892da1edda0549fa935130a691d26e24c6c           |
|                  | my7T8SSo2Rya1TPCNdzQVeWZP3roLbhx6d | tslm    | 0            | d23eb743fe8aed0aa2ed1fceae93b35aa7896ea2e2c35d8ae2c217c95b426311           |
+------------------+------------------------------------+---------+--------------+----------------------------------------------------------------------------+

My expectation was the -i flag would be ignored.

d5000 commented 3 months ago

-i flag here seems to work correctly, showing also P2TH addresses without any balances, at least on my side.

It could make sense to make -i standard for P2TH, because maybe the user would like to simply see which P2TH addresses exist, the balance isn't that interesting. If you don't object I'll implement it that way.

buhtignew commented 3 months ago

-i flag here seems to work correctly, showing also P2TH addresses without any balances, at least on my side.

Probably on my side too (I don't know how to verify whether the addresses without coins are P2TH or not on my side). What I'm seeing that there are some addresses that ends with SIGNALLING, VOTING and so on and the others are not that has made me think they weren't P2TH. But maybe I'm wrong.

If you don't object I'll implement it that way.

I'm not sure we should dedicate our time to this implementation. I don't feel it as urgent, TBH.

the balance isn't that interesting

For those who'll try to put their hands on the P2TH fees that info would be important, I guess :-)

d5000 commented 3 months ago

What I'm seeing that there are some addresses that ends with SIGNALLING, VOTING and so on and the others are not that has made me think they weren't P2TH. But maybe I'm wrong.

Those which do not have these words at the end are the main P2TH addresses of each token (the account name is simply the Deck ID). Every token has one of these addresses. dPoD tokens have various P2TH, that's why their P2TH accounts have these words at the end.

Making -i standard for P2TH addresses is simply change a word "False" to "True", so there is basically no work needed.

buhtignew commented 3 months ago

Making -i standard for P2TH addresses is simply change a word "False" to "True", so there is basically no work needed.

If you prefer to have it as a standard it's ok for me.

d5000 commented 2 months ago

Implemented it. Commit is c91609b. Closing as this needs no testing.

The reason I finally implemented it is that P2TH balances are all the time sent around as the SLM client considers them part of the balance, so the user doesn't even see which addresses are actually actively used if not using -i. The only use case for -p without -i would indeed be to grab p2th balances, but then you can still call it with -i False (and it's not a behaviour that should be promoted by the way ;) ).