search

slimcoin-project / pacli

Simple CLI PeerAssets client (extended version).
GNU General Public License v3.0
0 stars 0 forks source link

Default --sign and --send values in dex #172

Closed buhtignew closed 3 months ago

buhtignew commented 3 months ago

I've begun looking into the dex group of commands and have seen that in case of the dex lock command both --sign and --send are defaulted to false as well as the --sign of the dex exchange command, while the default value of the finalize_exchange --send flag is set to true. I'd like to ask whether it's intended because we've set those values to true in the other groups, but I assume that while exchanging tokens with strangers one should be a little bit more careful. If this is the idea, I was wondering why the finalize_exchange command has the true default value.

d5000 commented 3 months ago

This was simply still not updated to the "sign/send=True" policy and had no "deeper" reason. I have set all values to True already in an earlier update. Thus I'm closing.