token init in case of identical global names

[buhtignew]

This issue refers to our decision to remove the last remaining dialog we have in the code, as mentioned here:

Alright, I've removed the dialog.

Commit: https://github.com/slimcoin-project/pacli/commit/c1f2c94b9e3999c7b24bd9006c3be4e56154d236

I've tested the new set up and it seems like it works like this:

• if there are two decks with the same global name and I initialize one with less confirmations first the local label is not being attributed, but the initialization process succeeds. And I'm being notified with the line of white characters that the "Earlier decks have priority to be used as local labels, thus no local label was stored.";
• when after that I run the initialization on the other deck, one that has more confirmations, the process runs smoothly without any particular warning or notice and the global label is being saved as a local one automatically;
• the same happens when I run the earlier deck initialization first (on another set of decks with another identical global name);
• if then, after I've run the earlier deck initialization, I initialize the other one the process doesn't succeed and I receive two lines of read warning. In my case they were as following:

  Error: Storage of deck ID 85e7cbdedf4163fe4af44d17f3ff7a4eb7ac38f3d777307e12f8e3b0f3f8675b failed, label same1 already exists for a deck.
  Store manually using 'pacli deck set LABEL 85e7cbdedf4163fe4af44d17f3ff7a4eb7ac38f3d777307e12f8e3b0f3f8675b' with a custom LABEL value.

I think that by removing the dialog we can opt to attract the user's attention as much as possible to the fact that there are conflicting global names of the decks he is about to use. The easiest way, IMO, would be to abort the initialization process regardless whether the conflicting deck was spawn before or after the other one (i.e. in all the 4 aforementioned cases) and to make the user assign the local label manually.

Another idea could be to add to the global name the first 5 characters of the deck's id (provided they differs) thus assigning the local label automatically and after that issue a warning that there is more than one deck with the same global name.

[d5000]

The easiest way, IMO, would be to abort the initialization process regardless whether the conflicting deck was spawn before or after the other one (i.e. in all the 4 aforementioned cases) and to make the user assign the local label manually.

Taking into account the reason why this "priority" was chosen, I categorically reject this change. This would give spammers the opportunity to cause confusion among users of even popular tokens in launching tokens with the same global name.

The current system ensures that the first token with a certain global name will have always a "priority treatment", and it encourages people to use unique global names for their tokens. This policy is "soft" already (because PeerAssets' global names are not unique due to its design) but weakening it further would create less incentives to use unique names and more confusion for the user.

For this reason, I think also your other proposal (adding a part of the deck ID) doesn't improve the process, because it would also damage the "priority" of the first token launched with a global name. If any, this should be an optional feature for power users who want to follow a high number of tokens.