search

slime-io / slime

An intelligent ServiceMesh manager based on Istio
https://slime-io.github.io/
Other
420 stars 79 forks source link

meshreg: adjusted the position of args Rectify and Validate #509

Closed believening closed 1 month ago

believening commented 1 month ago

We moved the logic of meshreg args rectify and validate to where they were defined and extracted the same parts.

And below is the new cover result:

$ make test
?       slime.io/slime/modules/limiter  [no test files]
?       slime.io/slime/modules/limiter/api/config       [no test files]
?       slime.io/slime/modules/limiter/api/v1alpha2     [no test files]
?       slime.io/slime/modules/limiter/controllers/multicluster [no test files]
?       slime.io/slime/modules/limiter/model    [no test files]
?       slime.io/slime/modules/limiter/module   [no test files]
?       slime.io/slime/modules/meshregistry     [no test files]
?       slime.io/slime/modules/meshregistry/api/config  [no test files]
?       slime.io/slime/modules/meshregistry/api/v1alpha1        [no test files]
?       slime.io/slime/modules/meshregistry/controllers [no test files]
?       slime.io/slime/modules/meshregistry/model       [no test files]
?       slime.io/slime/modules/meshregistry/pkg/features        [no test files]
?       slime.io/slime/modules/meshregistry/pkg/mcpoverxds      [no test files]
?       slime.io/slime/modules/meshregistry/pkg/monitoring      [no test files]
?       slime.io/slime/modules/meshregistry/pkg/multicluster    [no test files]
?       slime.io/slime/modules/meshregistry/pkg/server  [no test files]
ok      slime.io/slime/modules/limiter/controllers      11.447s coverage: 46.0% of statements
ok      slime.io/slime/modules/limiter/test/e2e 0.052s  coverage: [no statements]
?       slime.io/slime/modules/meshregistry/pkg/source/k8s      [no test files]
?       slime.io/slime/modules/meshregistry/pkg/source/k8s/fs   [no test files]
ok      slime.io/slime/modules/meshregistry/module      10.991s coverage: 63.5% of statements
ok      slime.io/slime/modules/meshregistry/pkg/bootstrap       0.046s  coverage: 22.2% of statements
ok      slime.io/slime/modules/meshregistry/pkg/source  0.137s  coverage: 47.6% of statements
ok      slime.io/slime/modules/meshregistry/pkg/source/eureka   0.137s  coverage: 47.4% of statements
ok      slime.io/slime/modules/meshregistry/pkg/source/nacos    0.136s  coverage: 27.2% of statements
ok      slime.io/slime/modules/meshregistry/pkg/source/sourcetest       0.059s  coverage: 13.3% of statements
ok      slime.io/slime/modules/meshregistry/pkg/source/zookeeper        0.135s  coverage: 37.6% of statements
?       slime.io/slime/modules/meshregistry/pkg/util/cache      [no test files]
?       slime.io/slime/modules/plugin   [no test files]
?       slime.io/slime/modules/plugin/api/config        [no test files]
?       slime.io/slime/modules/plugin/api/v1alpha1      [no test files]
ok      slime.io/slime/modules/meshregistry/pkg/util    0.049s  coverage: 5.4% of statements
?       slime.io/slime/modules/plugin/model     [no test files]
?       slime.io/slime/modules/plugin/module    [no test files]
ok      slime.io/slime/modules/plugin/controllers       7.009s  coverage: 37.2% of statements