search

slime-lang / phoenix_slime

Phoenix Template Engine for Slime
MIT License
310 stars 65 forks source link

Support Phoenix 1.4 #64

Closed scarfacedeb closed 5 years ago

scarfacedeb commented 5 years ago

I updated deps to support Phoenix 1.4.0-rc and dropped Cowboy, because I don't think it's needed here.

Also I deleted phoenix.* tasks, because phoenix 1.4 removed them too.

mschae commented 5 years ago

Any news on this? Phoenix 1.4 was since released (would be great it @scarfacedeb could update the PR accordingly). Would be great to get this merged and released, soon. If there's any help we can provide please let me know.

scarfacedeb commented 5 years ago

@mschae @doomspork I updated mix.exs to use phoenix 1.4 and templates to use Routes. module for path helpers.

I think it should be ready to merge.

vtm9 commented 5 years ago

@doomspork can you merge this PR?

Rakoth commented 5 years ago

@doomspork I think, it is good to merge!

lessless commented 5 years ago

@doomspork do the needed please :)

doomspork commented 5 years ago

Sorry about that @scarfacedeb! I didn't realize @Rakoth didn't have permissions (I fixed that).

We're always looking for more contributors if you're interesting in helping maintain the Phoenix packages (and create one for LiveView). I'm not currently using Phoenix for many of my projects at work so keeping up with the developments to stay ahead of these packages is tough.

navinpeiris commented 5 years ago

Any chance of getting a new release with this merge as well please? Thanks for all your work peeps! ❤️

scarfacedeb commented 5 years ago

@doomspork Sure, I'll be glad to help!

I'm building API phoenix apps for the most part, but I have a couple of personal projects with slim templates too.

doomspork commented 5 years ago

@navinpeiris done! Sorry for the delays, lots on my plate these days 🙁

navinpeiris commented 5 years ago

completely understand @doomspork, thanks so much! ❤️