search

slime-lang / phoenix_slime

Phoenix Template Engine for Slime
MIT License
310 stars 66 forks source link

Elixir 1.8 compatibility #68

Closed stevegraham closed 3 years ago

stevegraham commented 5 years ago

Is Slime compatible with Elixir 1.8? It looks like EEx.Engine.handle_begin/1 implementation changed from ignoring the argument and returning an empty string, to expecting a map and raising a bad map error because it's called with a tuple, e.g. {:safe, [{:|, [], ["", "<h1>Reset your password</h1>"]}]}

doomspork commented 5 years ago

Howdy @stevegraham! I have not had a chance to try out Slime on 1.8 but if EEx changed then we'll need to incorporate some changes. I'll create an issue under https://github.com/slime-lang/slime to investigate 1.8 support.