search

slime-lang / slime

Minimalistic HTML templates for Elixir, inspired by Slim.
http://slime-lang.com
MIT License
368 stars 57 forks source link

Consider removing IE conditionals (/[if IE]) #127

Closed little-bobby-tables closed 7 years ago

little-bobby-tables commented 7 years ago

Support for conditional comments was removed in IE10, which itself has reached the end of life more than a year ago.

That's not the main reason I'm bringing this up, however. The problem is in the way it's currently implemented in Slime: the content of the conditional is not parsed (like it should be), rather, it is treated as plain text. This defeats the purpose of <!--[if IE]>, which is to inject browser-specific DOM elements.

Fixing the behavior will increase the complexity of the parser — why not just remove it? In case it's absolutely necessary, the conditionals can be inserted as ordinary HTML tags anyway:

<!--[if IE 9]>
    p Get a better browser
<![endif]-->
Rakoth commented 7 years ago

+1 to drop support

doomspork commented 7 years ago

Let's remove it!

Rakoth commented 7 years ago

closed by #128