search

slimgroup / JUDI.jl

Julia Devito inversion.
https://slimgroup.github.io/JUDI.jl
MIT License
96 stars 29 forks source link

Fix tutorial to use the correct squared slowness and remove JUDI4Flux info #162

Closed ziyiyin97 closed 1 year ago

ziyiyin97 commented 1 year ago

https://github.com/slimgroup/JUDI.jl/blob/master/examples/notebooks/01_intro.ipynb contains a mistake where it uses compressional wavespeed vp to construct a model instead of squared slowness m. Fixed in this PR. Also update the wordings a bit since https://github.com/slimgroup/JUDI4Flux.jl is deprecated.

mloubout commented 1 year ago

Hum looks like CI is broken because of my changes to SegyIO will look into it and fix

codecov[bot] commented 1 year ago

Codecov Report

Base: 81.83% // Head: 81.83% // No change to project coverage :thumbsup:

Coverage data is based on head (9530bb9) compared to base (9530bb9). Patch has no changes to coverable lines.

:exclamation: Current head 9530bb9 differs from pull request most recent head c8f9f56. Consider uploading reports for the commit c8f9f56 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #162 +/- ## ======================================= Coverage 81.83% 81.83% ======================================= Files 28 28 Lines 2186 2186 ======================================= Hits 1789 1789 Misses 397 397 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=slimgroup). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=slimgroup)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.