search

slimgroup / JUDI.jl

Julia Devito inversion.
https://slimgroup.github.io/JUDI.jl
MIT License
96 stars 29 forks source link

`judiTopmute` ERROR: n not defined #165

Closed kerim371 closed 1 year ago

kerim371 commented 1 year ago

Hi,

It seems n is missing here. It should probably be:

judiTopmute(n::NTuple{N, Integer}, wb::Array{T, Nw}, taperwidth::Integer) where {T, N, Nw} = TopMute(prod(n), wb, taperwidth)

# instead of:
# judiTopmute(::NTuple{N, Integer}, wb::Array{T, Nw}, taperwidth::Integer) where {T, N, Nw} = TopMute(prod(n), wb, taperwidth)
mloubout commented 1 year ago

It is indeed missing for that case looks like only the integer case is tested. Should be easy to fix