search

slimgroup / JUDI.jl

Julia Devito inversion.
https://slimgroup.github.io/JUDI.jl
MIT License
96 stars 30 forks source link

LSRTM objective options #64

Closed mloubout closed 3 years ago

mloubout commented 3 years ago

Fixes #63

codecov[bot] commented 3 years ago

Codecov Report

Merging #64 (2222ddd) into master (762706f) will increase coverage by 0.07%. The diff coverage is n/a.

:exclamation: Current head 2222ddd differs from pull request most recent head f8c1aac. Consider uploading reports for the commit f8c1aac to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   83.41%   83.49%   +0.07%     
==========================================
  Files          35       35              
  Lines        2321     2320       -1     
==========================================
+ Hits         1936     1937       +1     
+ Misses        385      383       -2
Impacted Files Coverage Δ
src/JUDI.jl 100.00% <ø> (ø)
...rc/TimeModeling/Modeling/lsrtm_objective_serial.jl 86.95% <0.00%> (+8.69%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 762706f...f8c1aac. Read the comment docs.

ziyiyin97 commented 3 years ago

Also fix #61

mloubout commented 3 years ago

CI went from <40min to almost 2h, that's way too much

ziyiyin97 commented 3 years ago

Change to 1 source in CI so it could be finished in 40 min (TTI+FS+optimal checkpointing takes a while) Rebased How about now? @mloubout

ziyiyin97 commented 3 years ago

@mloubout Is this the correct way to rebase? I am afraid I messed it up?

mloubout commented 3 years ago

Don't know what happened but definitely not correctly done. I can walk you through it tmr if you want

ziyiyin97 commented 3 years ago

That's very helpful! Thanks!!

mloubout commented 3 years ago

Didn't hear back so did it myself.

ziyiyin97 commented 3 years ago

Is this PR ready to merge?