Closed ziyiyin97 closed 1 year ago
Merging #92 (8f48783) into master (204ac0e) will decrease coverage by
1.16%
. The diff coverage is44.57%
.
@@ Coverage Diff @@
## master #92 +/- ##
==========================================
- Coverage 74.16% 73.00% -1.17%
==========================================
Files 24 24
Lines 1858 1941 +83
==========================================
+ Hits 1378 1417 +39
- Misses 480 524 +44
Impacted Files | Coverage Δ | |
---|---|---|
src/JUDI.jl | 83.33% <ø> (ø) |
|
src/TimeModeling/Types/GeometryStructure.jl | 83.33% <0.00%> (-8.63%) |
:arrow_down: |
src/TimeModeling/LinearOperators/operators.jl | 58.90% <22.85%> (-11.37%) |
:arrow_down: |
src/TimeModeling/Types/judiVector.jl | 92.56% <96.66%> (+1.04%) |
:arrow_up: |
src/TimeModeling/Types/abstract.jl | 75.42% <0.00%> (+1.69%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 204ac0e...8f48783. Read the comment docs.
Thanks for your feedback. Running time is less than 1.5 minutes for each example on my laptop so I don't think that affects the CI run time that much. These are just toy examples -- they might not produce super beautiful images in the end. I'll clean things up a bit then
Ideal set-up for sim source is to have a JOLI operator W
and it could be applied on q
, dobs
, F
, J
. Basically, I envisage the process of taking the gradient to look like
r = W * J * x - W * dobs
g = J' * W' * r
so that these symbols are exactly what they are in the paper.
I think doing W*q
and W*dobs
would be straightforward, but doing W*F
and W*J
needs some thought because we don't want to evaluate F
or J
first. Same deal for adjoint. My current thought is to do something like this
W
its own struct, namely judiSimSrcW <: joAbstractLinearOperator
*(::judiSimSrcW, ::judiJacobian)
to output a new judiJacobian
, NOT composition of JOLI operators*(::judiSimSrcW, ::judiPDEfull)
to output a new judiPDEfull
J'*W'
and F'*W'
Any comment or suggestion? @mloubout thanks
That's the idea yes. Need to be careful about weights redrawing and such as well
FYI things gonna change (for better) https://github.com/slimgroup/JUDI.jl/compare/refactor-22
So if you can keep it in mind. Only point source part is working for now.
There are still things to be fixed but I would appreciate a quick look at this file to make sure I am doing it the correct way https://github.com/slimgroup/JUDI.jl/blob/8b680bd6453b814b42cd20c758e6a40a0607f21b/src/TimeModeling/LinearOperators/operators.jl
Closing as stale and ended up doing simsourcer myself since nothing was happening here
doc
folder