search

slimgroup / JUDI.jl

Julia Devito inversion.
https://slimgroup.github.io/JUDI.jl
MIT License
96 stars 30 forks source link

Fix src geometry by convertToCell #94

Closed ziyiyin97 closed 2 years ago

ziyiyin97 commented 2 years ago

fix #93

This would really be the minimal change, i.e. if. key is source, then do convertToCell. A couple of test cases need to be adjusted according to the change. Another change I made it to make Geometry struct typed. This has nothing to do with the problem itself, but why not : )

codecov[bot] commented 2 years ago

Codecov Report

Merging #94 (8743d35) into master (26973e5) will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   84.64%   84.69%   +0.05%     
==========================================
  Files          30       30              
  Lines        2338     2346       +8     
==========================================
+ Hits         1979     1987       +8     
  Misses        359      359
Impacted Files Coverage Δ
src/TimeModeling/Types/GeometryStructure.jl 93.93% <100.00%> (+0.30%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26973e5...8743d35. Read the comment docs.

ziyiyin97 commented 2 years ago

The project.toml got v2.6.5 from the last PR #91 but you didn't release v2.6.5 yet in the github Releases. So I think we still leave v2.6.5 in project.toml and release it? It is an addition to PR #91 anyway @mloubout

mloubout commented 2 years ago

Yes will make a new release at some point with the various minor PRs