search

slimgroup / JutulDarcyRules.jl

JutulDarcyRules: ChainRules extension to Jutul and JutulDarcy
https://doi.org/10.5281/zenodo.7587716
MIT License
11 stars 3 forks source link

Fix PhaseViscosities #14

Closed gbruer15 closed 1 year ago

gbruer15 commented 1 year ago

The PhaseViscosities parameter was not being set correctly in setup_well_model. I added a fix for it as well as a test for it.

@ziyiyin97 I decided the fix was better here than in JutulDarcy, but my "fix" causes a gradient test to fail. Can you take a look at this sometime?

ziyiyin97 commented 1 year ago

Can you fix the conflict? Also, wouldn't it be straightforward to fix this in JutulDarcy instead of here? Thoughts?

ziyiyin97 commented 1 year ago

Superceded by https://github.com/sintefmath/JutulDarcy.jl/pull/10

ziyiyin97 commented 1 year ago

Close since https://github.com/sintefmath/JutulDarcy.jl/pull/10 is merged

ziyiyin97 commented 1 year ago

After thinking about this, I agree that this still needs to be addressed here ... can you give me write access to your repo so that I could work on fixing the gradient tests? I've also given you written access to this repo so you can also work on branches here directly @gbruer15

gbruer15 commented 1 year ago

Fixed in #20