Closed gbruer15 closed 1 year ago
Can you fix the conflict? Also, wouldn't it be straightforward to fix this in JutulDarcy instead of here? Thoughts?
Superceded by https://github.com/sintefmath/JutulDarcy.jl/pull/10
Close since https://github.com/sintefmath/JutulDarcy.jl/pull/10 is merged
After thinking about this, I agree that this still needs to be addressed here ... can you give me write access to your repo so that I could work on fixing the gradient tests? I've also given you written access to this repo so you can also work on branches here directly @gbruer15
Fixed in #20
The PhaseViscosities parameter was not being set correctly in
setup_well_model
. I added a fix for it as well as a test for it.@ziyiyin97 I decided the fix was better here than in JutulDarcy, but my "fix" causes a gradient test to fail. Can you take a look at this sometime?