line endings fix - Githubissues

slimm609 / checksec.sh

Checksec.sh

https://slimm609.github.io/checksec.sh/

Other

1.99k stars 299 forks source link

line endings fix #200

Closed calebTree closed 2 years ago

calebTree commented 2 years ago

I cloned on Windows, then copied to a Unix machine and the line endings were wrong in checksec.

.gitattributes (*.sh) should ensure line endings are correct.

I assume checksec did not have *.sh by design. Just curious if this update is worth it to the maintainers?

slimm609 commented 2 years ago

No, it should not have an extension this is intentional and won't be changed. This is not a recommended practice.

https://google.github.io/styleguide/shellguide.html#file-extensions

calebTree commented 2 years ago

No, it should not have an extension this is intentional and won't be changed. This is not a recommended practice.

https://google.github.io/styleguide/shellguide.html#file-extensions

Thanks for the reference documentation. I had never seen or read about that before.

slimm609 commented 2 years ago

Can you remove the rename and I can merge the line ending fix

calebTree commented 2 years ago

Can you remove the rename and I can merge the line ending fix

I made a new pr #203. It completely slipped my mind to just explicitly define an additional filter directive for checksec.

The only reason I made a new PR is because this really is a one commit change and I'm not sure what your opinion is regarding forcing a push to a PR. I ended up forcing a push to #203 because I didn't notice apparently the results of the dos2unix command got committed to checksec.