search

slimphp / PHP-View

A Simple PHP Renderer for Slim 3 & 4 (or any other PSR-7 project)
MIT License
263 stars 60 forks source link

Need consistent naming to fix autoloading #12

Closed josephscott closed 9 years ago

josephscott commented 9 years ago

As it stands right now PHP-View doesn't work because the Composer autoloader doesn't match a PhpRenderer class name against a PHPRenderer.php file name.

One of two things needs to happen:

Both of these approaches fixed autoloading for me. I suspect the first option would be preferred, but I'd be fine with either one since I'm more concerned about it working than the naming style.

akrabat commented 9 years ago

I'd prefer the first one too.

geggleto commented 9 years ago

interesting that it works fine for me when I run the tests locally ...

akrabat commented 9 years ago

Fixed with PR #13.

@josephscott I'd appreciate it if you could test and confirm.

geggleto commented 9 years ago

At least in my case I didn't have the issue to begin with. Thanks @josephscott

josephscott commented 9 years ago

@akrabat confirmed, 2.0.5 works fine.

@geggleto any chance you are using a filesystem that is not case sensitive?

geggleto commented 9 years ago

@josephscott Yeah I am on windows ;)