Catch code replaced with finally to keep the code DRY.

slimphp / PHP-View

A Simple PHP Renderer for Slim 3 & 4 (or any other PSR-7 project)

MIT License

264 stars 60 forks source link

Catch code replaced with finally to keep the code DRY. #35

Closed DennisSkoko closed 7 years ago

DennisSkoko commented 7 years ago

Instead of catching multiple exceptions, I replaced the catch with finally. That way the exception is re-thrown while the output buffer always gets cleaned and closed.

Regards, Dennis Skoko

DennisSkoko commented 7 years ago

No feedback? I thought it didn't break anything and I just didn't want the code to be all wet.

silentworks commented 7 years ago

@geggleto can you leave some feedback as to why this was closed please.