slimphp / PHP-View

A Simple PHP Renderer for Slim 3 & 4 (or any other PSR-7 project)
MIT License
264 stars 60 forks source link

PHP 8 support #65

Closed Ayesh closed 3 years ago

Ayesh commented 4 years ago
Ayesh commented 3 years ago

Hi @l0gicgate - thanks a lot for reviewing this. This PR was made before PHPUnit 9 had PHP 8 support in composer.json, and before PHPUnit 8.5 fixed compatibility issues with PHP 8. So I had to use ignore-platform-reqs to bypass Composer validating them.

I removed them, and will mark this PR as ready.

Travis internally does not provide PHP 8 under trusty (14 LTS), so I also updated to xenial (16 LTS) for PHP 8 builds, which now supports all PHP versions we test against.

All tests now pass as well.

Thank you.

akrabat commented 3 years ago

Thanks for your work on this. Due to our tardiness, there were multiple PRs raised and I picked #71.