search

slimphp / Slim-Http

A set of PSR-7 object decorators providing useful convenience methods
MIT License
151 stars 46 forks source link

Question: rewind() after pulling ServerRequest body contents? #102

Open BusterNeece opened 5 years ago

BusterNeece commented 5 years ago

I've noticed that in the decorated ServerRequest, when calling getParsedBody, the original body is pulled via (string)$request->getBody(), but the StreamInterface is not rewind-ed after the fact.

In my tests, this means that any call to $request->getBody()->getContents() that takes place after that call happens have the internal stream pointer moved to the end of the input stream, and thus pulls basically always nothing.

I'm not sure if this is just a natural and intended byproduct of how PSR-7's StreamInterface works, or if this is something that could be worked around at this level.

l0gicgate commented 5 years ago

We're having an ongoing discussion about stream caching. See https://github.com/slimphp/Slim-Psr7/pull/124

This is just for Slim-Psr7 though. As for these decorators I'm thinking that maybe we should also do some automatic caching in order to enable multiple calls to $request->getBody()->getContents()