search

slimphp / Slim-Http

A set of PSR-7 object decorators providing useful convenience methods
MIT License
151 stars 46 forks source link

Possibility of removing final on constructors? #146

Closed dlundgren closed 3 years ago

dlundgren commented 3 years ago

The following classes had constructors that were converted to final in #118, and it'd be nice to not have them final for those of us who are extending the classes, and modifying the constructors.

I'm particularly interested in Response as I extend it to create a Redirect class that I use to more easily handle forwards (internal framework), and actual redirects.

l0gicgate commented 3 years ago

Remove them and run static analysis, you’ll understand why we shouldn’t.