Closed akrabat closed 1 year ago
@akrabat I'm not sure I understand the coveralls bit you changed, it seems to not be reporting status with that change now. Am I mistaken?
Otherwise looks good to me.
@akrabat I'm not sure I understand the coveralls bit you changed, it seems to not be reporting status with that change now. Am I mistaken?
Otherwise looks good to me.
You're not mistaken. Clearly not quite there yet!
Update dependencies and commit composer.lock. With composer.lock in the project CI will build against a known set of dependencies which will make it easier for testing as we'll know if a failed test is related to our changes. At the moment, the failure could be because of a dependency's changes.