search

slimphp / Slim-Psr7

PSR-7 implementation for use with Slim 4
MIT License
133 stars 45 forks source link

Remove dependency on ralouphie/getallheaders #273

Closed williamdes closed 1 year ago

williamdes commented 1 year ago

This was added in https://github.com/slimphp/Slim-Psr7/pull/76 Then moved as a normal dependency in https://github.com/slimphp/Slim-Psr7/pull/111 for https://github.com/slimphp/Slim-Psr7/issues/101

And got upgraded in https://github.com/slimphp/Slim-Psr7/pull/112

I see no reason this function would be now missing in PHP 7.4+

williamdes commented 1 year ago

I am starting to ask myself why it is absent or not on some systems I think this should not be merged for now. The error that is seen here is also seen on my Debian packaging where I do not have the polyfill. See: https://github.com/slimphp/Slim-Psr7/actions/runs/3609229456/jobs/6145955522#step:7:54

@ralouphie is your lib still open for maintenance ?

williamdes commented 1 year ago

I am closing this, but the library should get some maintenance. Depending on an old non maintained library is not very great