Improve `Header` by using PHP native types 🐘

slimphp / Slim-Psr7

PSR-7 implementation for use with Slim 4

MIT License

133 stars 45 forks source link

Improve `Header` by using PHP native types 🐘 #277

Closed nbayramberdiyev closed 1 year ago

nbayramberdiyev commented 1 year ago

This PR declares PHP native type for the parameter $values of the Header::addValues method, removes related test method and superfluous PHPDoc annotations. This way, we no longer need to manually check if the value is string or array.

coveralls commented 1 year ago

Coverage: 100.0%. Remained the same when pulling 7c83e37fbcdd22f8e586cf83fbbcf23933d8fe01 on nbayramberdiyev:improve-header into bd76383642ad2c217a9238e6b1e61859d075c4aa on slimphp:master.

l0gicgate commented 1 year ago

Thank you for this contribution @nbayramberdiyev