Cast `Uri@filterPort()` `$port` parameter to string if non-null

slimphp / Slim-Psr7

PSR-7 implementation for use with Slim 4

MIT License

133 stars 45 forks source link

Cast `Uri@filterPort()` `$port` parameter to string if non-null #295

Closed cosmastech closed 5 months ago

cosmastech commented 11 months ago

To resolve https://github.com/slimphp/Slim-Psr7/issues/288

l0gicgate commented 11 months ago

@cosmastech it appears that CI is failing on 8.2 now

cosmastech commented 11 months ago

@cosmastech it appears that CI is failing on 8.2 now

This isn't related to anything I changed (and is also failing on https://github.com/slimphp/Slim-Psr7/pull/294/files). Maybe should be a separate PR to remove that phpstan rule?

coveralls commented 5 months ago

coverage: 99.872% (+0.001%) from 99.871% when pulling 132ae6520f26db8232d774748d386a3d7dc3aa8c on cosmastech:fix/port-as-string into 3a1dd1deab0ae2bb95c4502389671123689a4892 on slimphp:master.

akrabat commented 5 months ago

Thanks. I'm sorry that it took so long.

cosmastech commented 5 months ago

Thanks. I'm sorry that it took so long.

No problem. Thanks for letting me contribute!