search

slimphp / Slim-Skeleton

Slim Framework 4 Skeleton Application
http://www.slimframework.com
MIT License
1.59k stars 479 forks source link

Adding rateLimit middleware #186

Closed amireshoon closed 4 years ago

amireshoon commented 4 years ago

Hey, My changes are all about rate-limiting for PHP and slim. The middleWare was also available on https://github.com/amireshoon/RateLimitMicroFrameWork .

ojgarciab commented 4 years ago

Warning: @amireshoon, your code doesn't support concurrent updates to data file (by dafault ../tmp/rate_limit/rate.limit), so it is sensitive to data corruption and/or race conditions.

l0gicgate commented 4 years ago

I'm sorry but this is not something that we will be adding to the skeleton. Rate limiting middleware isn't all that common and is quite a complex problem to solve. Starter projects wouldn't be needing this.

Thank you for an attempt at contributing though.