slimphp / Slim

Slim is a PHP micro framework that helps you quickly write simple yet powerful web applications and APIs.
http://slimframework.com
MIT License
11.98k stars 1.95k forks source link

[Slim3] Do not assume response body stream is seekable #1434

Closed codeguy closed 9 years ago

codeguy commented 9 years ago

Not all streams are seekable, and we should not assume this here:

https://github.com/slimphp/Slim/blob/3.x/Slim/App.php#L352

This bit me when trying to send a Guzzle PumpStream which tosses an exception when you try to seek it. I'll send a PR shortly.

geggleto commented 9 years ago

I am pretty sure this came about from the discussion about php://input not being seekable