[v3.3.0] Return response withJson status not working

Loic-Rameau commented 8 years ago

I guys, i've came accros difficulty with routing.

Here some code that works for me :

/**
 * @var Slim\App $app
 */
$this->get('/{slug:[a-zA-Z0-9_-]+}/agencies[/dpts/{dpts:\d+}]', function (Request $request, Response $response, $args) use ($database, $slug, $app) {
        $entity = Entity::getItem([
            [
                'column'=>$slug,
                'operator'=>'=',
                'value'=>$args['slug']
            ]
        ]);
        if($entity === false){
            $app->respond($response->withJson([
                'error'=>'Unknown Entity',
                'code'=>404
            ], 400));
            exit();
        }

        $response->getBody()->write(Agency::getItemsJson(
            $where, 'cp'
        ));
        return $response;
});

Here some that don't :

/**
 * @var Slim\App $app
 */
$this->get('/{slug:[a-zA-Z0-9_-]+}/agencies[/dpts/{dpts:\d+}]', function (Request $request, Response $response, $args) use ($database, $slug, $app) {
        $entity = Entity::getItem([
            [
                'column'=>$slug,
                'operator'=>'=',
                'value'=>$args['slug']
            ]
        ]);
        if($entity === false){
            return $response->withJson([
                'error'=>'Unknown Entity',
                'code'=>404
            ], 400);
        }

        $response->getBody()->write(Agency::getItemsJson(
            $where, 'cp'
        ));
        return $response;
});

And i can't figure why the second one doesn't work. It returns the given json :

{
 "error": "Unknown Entity",
 "code": 404
}

But with a HTTP code of 200 and not 400 as given in parameter.

The fact is that if i do :

/**
 * @var Slim\App $app
 */
$this->get('/{slug:[a-zA-Z0-9_-]+}/agencies[/dpts/{dpts:\d+}]', function (Request $request, Response $response, $args) use ($database, $slug, $app) {
        $entity = Entity::getItem([
            [
                'column'=>$slug,
                'operator'=>'=',
                'value'=>$args['slug']
            ]
        ]);
        if($entity === false){
           $newResponse = $response->withStatus(400)->withJson([
                'error'=>'Unknown Entity',
                'code'=>404
            ]);
           return $newResponse;
        }

        $response->getBody()->write(Agency::getItemsJson(
            $where, 'cp'
        ));
        return $response;
});

This as the same effect. The Json is correctly send but with a wrong HTTP code 200 instead of 400. I almost lost a day figuring why my code wouldn't work, and i find annoying to pass $app in every callback.

ppetermann commented 8 years ago

not sure why, but whoever added the method build it so it accepts a $status as second parameter. Have you tried:

       $newResponse = $response->withJson([
            'error'=>'Unknown Entity',
            'code'=>404
        ], 400);

Loic-Rameau commented 8 years ago

I did as i say earlier.


/**
 * @var Slim\App $app
 */
$this->get('/{slug:[a-zA-Z0-9_-]+}/agencies[/dpts/{dpts:\d+}]', function (Request $request, Response $response, $args) use ($database, $slug, $app) {
        $entity = Entity::getItem([
            [
                'column'=>$slug,
                'operator'=>'=',
                'value'=>$args['slug']
            ]
        ]);
        if($entity === false){
            return $response->withJson([
                'error'=>'Unknown Entity',
                'code'=>404
            ], 400);
        }

        $response->getBody()->write(Agency::getItemsJson(
            $where, 'cp'
        ));
        return $response;
});

The responses have the good data but not the status.