V4 proposal: Replace Pimple with a variant of Set

slimphp / Slim

Slim is a PHP micro framework that helps you quickly write simple yet powerful web applications and APIs.

http://slimframework.com

MIT License

11.94k stars 1.95k forks source link

V4 proposal: Replace Pimple with a variant of Set #1922

Closed akrabat closed 7 years ago

akrabat commented 8 years ago

Our needs for a DI container are really simple and we don't use anything in Pimple that we don't have in Set.

The main benefits are:

We don't need our extension class to make it container-interop as Set already implements the two methods required…
We don't have to worry about Pimple updates.

geggleto commented 8 years ago

We still would want to have DI Interoperability... so I guess we would simply create an Interface that people can implement on top of the DI Container of their choice.

JoeBengalen commented 8 years ago

Why create an interface? We should implement container-interop/container-interop.

geggleto commented 8 years ago

@JoeBengalen The set class does way more than containter-interop specifies... need to make sure that either

Slim only uses the ->get() and ->has()
We provide an interface to guide implementors of other container libraries

Example

If slim defines a bunch of services using Set::protect(), then other DI libraries also need to have that wired in.

This is loosely related too: https://github.com/slimphp/Slim/issues/1923

akrabat commented 7 years ago

Closing - not happening.