Slim\App: Obsoleted magic methods but their PHPDocs remain alive

slimphp / Slim

Slim is a PHP micro framework that helps you quickly write simple yet powerful web applications and APIs.

http://slimframework.com

MIT License

11.98k stars 1.95k forks source link

Slim\App: Obsoleted magic methods but their PHPDocs remain alive #1989

Closed acgrid closed 8 years ago

acgrid commented 8 years ago

As commit fb85bdbd8d5739a7f7e8c6172301b535ea16ab2c shows, Slim\App does not contains __isset() and __get() magic methods any more. However, its related phpdocs still present since then, see https://github.com/slimphp/Slim/blame/3.x/Slim/App.php#L38-L48

I've spent some minutes to figure out where these "mysterious" phpdocs come out. I suggest to evaluate whether introducing such magic methods or not, and remove superfluous phpdocs if magic methods are confirmed to be wiped out.

akrabat commented 8 years ago

Fixed in the upcoming version 3.6. Thanks for reporting.