slimtoolkit / slim

Slim(toolkit): Don't change anything in your container image and minify it by up to 30x (and for compiled languages even more) making it secure too! (free and open source)
Apache License 2.0
19.21k stars 716 forks source link

fix: Make the artifacts folder flag impl complete #438

Closed iximiuz closed 1 year ago

iximiuz commented 1 year ago

app stdout and stderr log files wouldn't be included if the --artifacts-dir flag was used.

Also, unify the spelling: it's artifactsDir (plural) now everywhere, not artifactDir (singular).

ghost commented 1 year ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=438&src=https%3A%2F%2Fgithub.com%2Fdocker-slim%2Fdocker-slim)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend