slimtoolkit / slim

Slim(toolkit): Don't change anything in your container image and minify it by up to 30x (and for compiled languages even more) making it secure too! (free and open source)

Apache License 2.0

19.33k stars 725 forks source link

add env-file flag to build command #573

Closed reetasingh closed 1 year ago

reetasingh commented 1 year ago

Fixes-###

What

Why

How Tested

kcq commented 1 year ago

The PR look ok. If you want you can also add 'env-file' to the 'profile' command, but that's nice to have (not a blocker for this PR).

kcq commented 1 year ago

can you also fix the DCO signature. the commits need to be signed for the DCO check to be happy :)

reetasingh commented 1 year ago

The PR look ok. If you want you can also add 'env-file' to the 'profile' command, but that's nice to have (not a blocker for this PR).

will work on this today and open the PR