slimtoolkit / slim

Slim(toolkit): Don't change anything in your container image and minify it by up to 30x (and for compiled languages even more) making it secure too! (free and open source)

Apache License 2.0

18.89k stars 704 forks source link

587 - Add validation for the --env flag and remove malformed one #588

Closed vash-knives closed 9 months ago

vash-knives commented 9 months ago

Fixes-###

What

To address issue #587 . This PR is to get an initial review of the direction of the changes.

Why

To have a proper check of the --env values and removing malformed ones without stopping the build

How Tested

Ran slim build with multiple combinations of the --env flag.

vash-knives commented 9 months ago

@kcq , made some changes to address your comments. Let me know what you think.

kcq commented 9 months ago

@kcq , made some changes to address your comments. Let me know what you think.

it's close enough to merge. thank you for making the enhancements!

vash-knives commented 9 months ago

@kcq glad to help! are there plans in refactoring the codebase? happy to help on that as well. i can pick up another issue in the meantime or continue with this issue until closed if there are changes still needed.