slince / shopify-api-php

:rocket: Shopify API Client for PHP
MIT License
128 stars 47 forks source link

Fixed Order model lose `created_at` property. #55

Closed hiscaler closed 3 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #55 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
+ Coverage     88.27%   88.29%   +0.01%     
- Complexity     1371     1373       +2     
============================================
  Files           100      100              
  Lines          3377     3382       +5     
============================================
+ Hits           2981     2986       +5     
  Misses          396      396
Impacted Files Coverage Δ Complexity Δ
src/Manager/Order/Order.php 100% <100%> (ø) 122 <2> (+2) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8a3fde2...f8ae8f4. Read the comment docs.

maximzasorin commented 4 years ago

Hello, thanks for your commit. In your commit you have added a receipt field definition for the Fulfillment model. Where did you get this definition? The API documentation has a completely different definition, maybe there is an error in the documentation, but how to check yours? How can I create Fulfillment with receipt field?

hiscaler commented 4 years ago

@maximzasorin I get from orders admin api. response data like follow:

{
    "receipt": {
        "gift_cards": [
            {
                "id": 111,
                "line_item_id": 222,
                "masked_code": "•••• •••• •••• 333"
            }
        ]
    }
}
maximzasorin commented 4 years ago

@hiscaler

I think we should clarify with the support or somewhere else this discrepancy. Maybe the value of this field does not have a constant format and depends on something, for example, as in the case of the receipt field for Transaction: https://help.shopify.com/en/api/reference/orders/transaction#receipt-property-2019-10

hiscaler commented 4 years ago

@maximzasorin Maybe, but i not add it, parse will be throw error.

slince commented 3 years ago

2.x version is coming to an end; can you send pr to 3.x branch?