500 if no Coordinates in Orderadress?

slince / shopify-api-php

:rocket: Shopify API Client for PHP

MIT License

128 stars 47 forks source link

500 if no Coordinates in Orderadress? #65

Open karatektus opened 4 years ago

karatektus commented 4 years ago

woke up to a weird bug today, see here:

karatektus commented 4 years ago

kay found it. see here: #66

slince commented 4 years ago

Hello, You seem to be using version 3.x, which is unstable; You should change minimum-stability: stable

karatektus commented 4 years ago

that was on purpose - master didn't work with symfony 5

slince commented 4 years ago

hello, In the 3.x , symfony/serializer was used instead of JMS /serializer; And here's a bug: https://github.com/symfony/symfony/issues/36079

Can you submit a pr to the master branch if possible?

karatektus commented 4 years ago

hi, symfony/serializer is the way forward imo anyway. A pr to master is a little complicated since i dont use it. wont you merge 3.x into master anyway?